Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- [Trace Metrics 29] Rename sample API param, remove sleep ([#5024](https://github.com/getsentry/sentry-java/pull/5024))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 6913b95

This was referenced Jan 13, 2026
Copy link
Member Author

adinauer commented Jan 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 314.19 ms 377.56 ms 63.37 ms
Size 1.58 MiB 2.20 MiB 635.32 KiB

Baseline results on branch: 01-12-automatically_use_sentryoptions.metrics.beforesendmetriccallback_spring_beans

Startup times

Revision Plain With Sentry Diff
352f3fd 308.80 ms 354.43 ms 45.62 ms

App size

Revision Plain With Sentry Diff
352f3fd 1.58 MiB 2.20 MiB 635.32 KiB

@adinauer adinauer changed the title Rename sample API param, remove sleep feat(metrics): [Trace Metrics 29] Rename sample API param, remove sleep Jan 13, 2026
@adinauer adinauer marked this pull request as ready for review January 14, 2026 06:03
@adinauer adinauer requested review from lcian and romtsn as code owners January 14, 2026 06:03
@adinauer
Copy link
Member Author

@sentry review

@adinauer
Copy link
Member Author

cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Base automatically changed from 01-12-automatically_use_sentryoptions.metrics.beforesendmetriccallback_spring_beans to feat/trace-metrics January 14, 2026 10:54
@adinauer adinauer merged commit f2dca3b into feat/trace-metrics Jan 14, 2026
59 of 65 checks passed
@adinauer adinauer deleted the 01-13-rename_sample_api_param_remove_sleep branch January 14, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants